[Webkit-unassigned] [Bug 81786] Initial support fixed position elements in Qt WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81786





--- Comment #28 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-04-03 04:11:13 PST ---
(From update of attachment 135263)
View in context: https://bugs.webkit.org/attachment.cgi?id=135263&action=review

> Source/WebCore/ChangeLog:8
> +        When the setting acceleratedCompositingForFixedPositionEnabled is true, we need to upadte

update

Couldn't the method be called something like userLayersForFixedElements or similar.

> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:517
> +FloatPoint TextureMapperLayer::normalizedScrollOffset(const IntPoint& webScrollOffset)

web? This doesn't tell me whethre this is in CSS coords or not.

> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:520
> +    float webScrollPositionX = std::max(webScrollOffset.x(), 0);
> +    webScrollPositionX = std::min(webScrollPositionX, m_contentsSize.width() - m_visibleContentsRect.width());

isn't there something like qBound?

This is offset from what? current position? because if so, then it should be possible to be negative. Or is this just scroll position?

> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:538
> +    float uiScrollPositionX = std::max(m_visibleContentsRect.x(), 0);

What value does ui add here?

> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:539
> +    uiScrollPositionX = std::min(uiScrollPositionX, m_contentsSize.width() - m_visibleContentsRect.width());

I have seen similar code elsewhere

> Source/WebKit2/Shared/WebLayerTreeInfo.cpp:38
> +    encoder->encode(CoreIPC::In(scrollOffset));

scrollPosition?

> Source/WebKit2/Shared/WebLayerTreeInfo.h:115
> +    WebCore::IntPoint scrollOffset;

an offset would be IntSize where as a position would be IntPoint

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.