[Webkit-unassigned] [Bug 81588] Array.prototype.toString should be generic

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81588





--- Comment #10 from hojong.han at samsung.com  2012-04-02 18:00:55 PST ---
(In reply to comment #9)
> (From update of attachment 135074 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=135074&action=review
> > Source/JavaScriptCore/runtime/ArrayPrototype.cpp:270
> > +                return JSValue::encode(jsMakeNontrivialString(exec, "[object ", thisObject->methodTable()->className(thisObject), "]"));
> This does not seem right. You should call the original Object.prototype.toString instead of duplicating its implementation.
> ...and add tests

Thanks for reveiw. I'll apply what you recommend and tests to the new patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.