[Webkit-unassigned] [Bug 81588] Array.prototype.toString should be generic

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81588


Erik Arvidsson <arv at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135074|review?                     |review-
               Flag|                            |




--- Comment #9 from Erik Arvidsson <arv at chromium.org>  2012-04-02 09:55:01 PST ---
(From update of attachment 135074)
View in context: https://bugs.webkit.org/attachment.cgi?id=135074&action=review

> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:270
> +                return JSValue::encode(jsMakeNontrivialString(exec, "[object ", thisObject->methodTable()->className(thisObject), "]"));

This does not seem right. You should call the original Object.prototype.toString instead of duplicating its implementation.


...and add tests

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.