[Webkit-unassigned] [Bug 82728] Split remaining CSSRules into internal and CSSOM types

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 2 08:09:11 PDT 2012


--- Comment #25 from Andreas Kling <kling at webkit.org>  2012-04-02 08:09:10 PST ---
(In reply to comment #24)
> (From update of attachment 135091 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=135091&action=review
> > Source/WebCore/css/CSSStyleSheet.cpp:95
> > +    , m_cssParserMode(ownerRule ? ownerRule->parentStyleSheet()->cssParserMode() : CSSStrictMode)
> Is this always a safe call? StyleRuleImport constructor always take a stylesheet as a parameter but clearParentStyleSheet is called in various places. Is there a scenario where the importRule will not have a parentStyleSheet?

Good point. If you remove the @import rule from its containing style sheet before the call to CachedCSSStyleSheet::checkNotify() happens, you could possibly have an unparented @import rule. We should keep the null check that the old version of this code had.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list