[Webkit-unassigned] [Bug 82728] Split remaining CSSRules into internal and CSSOM types

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 2 07:54:41 PDT 2012


Alexis Menard (darktears) <alexis.menard at openbossa.org> changed:

           What    |Removed                     |Added
 Attachment #135091|review+                     |review?
               Flag|                            |

--- Comment #24 from Alexis Menard (darktears) <alexis.menard at openbossa.org>  2012-04-02 07:54:40 PST ---
(From update of attachment 135091)
View in context: https://bugs.webkit.org/attachment.cgi?id=135091&action=review

> Source/WebCore/css/CSSStyleSheet.cpp:95
> +    , m_cssParserMode(ownerRule ? ownerRule->parentStyleSheet()->cssParserMode() : CSSStrictMode)

Is this always a safe call? StyleRuleImport constructor always take a stylesheet as a parameter but clearParentStyleSheet is called in various places. Is there a scenario where the importRule will not have a parentStyleSheet?

> Source/WebCore/css/CSSStyleSheet.cpp:175
> +            m_childRuleCSSOMWrappers[i]->setParentStyleSheet(0);

Seems like the indentation is wrong.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list