[Webkit-unassigned] [Bug 82577] Work around an entity parsing bug in libxml2 2.7.3 (supplied with Lion) and unskip tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82577





--- Comment #8 from Eric Seidel <eric at webkit.org>  2012-04-01 11:34:37 PST ---
(From update of attachment 134993)
View in context: https://bugs.webkit.org/attachment.cgi?id=134993&action=review

> Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:548
> +    , m_depthTriggeringEntityExpansion(-1)
> +    , m_isParsingEntityDeclaration(false)

Seems these should also be removed at compile time if the workaround is not in place.

> Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:743
> +#if LIBXML_VERSION >= 20704

Which suggests that this needs to be turned into a #define WORKAROUND_ENTITY_PARSING_BUG or similar, so it can be re-used as a compile time check in various places throughtout this file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.