[Webkit-unassigned] [Bug 82577] Work around an entity parsing bug in libxml2 2.7.3 (supplied with Lion) and unskip tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 1 10:56:09 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=82577





--- Comment #7 from Nikolas Zimmermann <zimmermann at kde.org>  2012-04-01 10:56:07 PST ---
(In reply to comment #6)
> (From update of attachment 134993 [details])
> Can you create a USE(LIBXML_ENTITY_PARSER_WORKAROUND) ifdef and put all this code behind the ifdef?  That will make it easier for us to remove it in the future.
I followed the existing style for another libxml workaround in the same file.
I don't see the benefit of adding USE() macro support for hacks like this - if you disable it in Platform.h at some point, you still need to remove it from the cpp file as well.

If I shall change it, the other libxml workaround needs to be changed as well. Is it worth it?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list