[Webkit-unassigned] [Bug 69107] Webkit API for compositor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69107





--- Comment #8 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-09-30 21:39:52 PST ---
(In reply to comment #6)
> (From update of attachment 109368 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=109368&action=review
> 
> > Source/WebKit/chromium/public/WebContentLayer.h:37
> > +namespace WebCore { class ContentLayerChromium; }
> 
> you shouldn't leak any WebCore things in the header. does this just need to be in a #if WEBKIT_IMPLEMENTATION guard?

Actually, we are not so strict about that these days.  This doesn't really hurt anything.  What would hurt is if someone could actually use this type for something in Chromium.  So long as we don't expose any functions that operate on these types, it should be fine.

The extra WEBKIT_IMPLEMENTATION guard is totally fine, but perhaps unnecessary.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.