[Webkit-unassigned] [Bug 69107] Webkit API for compositor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69107





--- Comment #6 from James Robinson <jamesr at chromium.org>  2011-09-30 19:07:57 PST ---
(From update of attachment 109368)
View in context: https://bugs.webkit.org/attachment.cgi?id=109368&action=review

> Source/WebKit/chromium/public/WebContentLayer.h:37
> +namespace WebCore { class ContentLayerChromium; }

you shouldn't leak any WebCore things in the header. does this just need to be in a #if WEBKIT_IMPLEMENTATION guard?

> Source/WebKit/chromium/public/WebContentLayer.h:49
> +    ~WebContentLayer() { }

virtual

> Source/WebKit/chromium/public/WebLayer.h:37
> +namespace WebCore { class LayerChromium; }

shouldn't this be inside a WEBKIT_IMPLEMENTATION guard? we shouldn't leak webcore types through this header

> Source/WebKit/chromium/public/WebLayer.h:50
> +    ~WebLayer() { reset(); }

if you wanna let people destroy WebLayers via a WebLayer*, virtual on this please

> Source/WebKit/chromium/public/WebLayerDelegate.h:16
> + *     * Redistributions of source code must retain the above copyright
> + * notice, this list of conditions and the following disclaimer.
> + *     * Redistributions in binary form must reproduce the above
> + * copyright notice, this list of conditions and the following disclaimer
> + * in the documentation and/or other materials provided with the
> + * distribution.
> + *     * Neither the name of Google Inc. nor the names of its
> + * contributors may be used to endorse or promote products derived from
> + * this software without specific prior written permission.

here and other files: we use a 2-clause license header for new code

> Source/WebKit/chromium/src/WebContentLayer.cpp:5
> + * copyright (c) 2011 google inc. all rights reserved.
> + *
> + * redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions are

somehow bizarrely this license header became totally lowercase

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.