[Webkit-unassigned] [Bug 69107] Webkit API for compositor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69107





--- Comment #5 from Antoine Labour <piman at chromium.org>  2011-09-30 16:18:13 PST ---
(In reply to comment #3)
> (From update of attachment 109216 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=109216&action=review
> 
> FYI Darin and I sketched up the input stuff in more detail and as a result https://bugs.webkit.org/show_bug.cgi?id=69117 changes the threading around a bit. I hope this doesn't complicate your design too much, I think it's actually a bit simpler to reason about with the thread managed externally to WebKit.

I removed the notion of thread for now. It wasn't working yet anyway. I'll follow up in a later CL.

> 
> > Source/WebKit/chromium/public/WebContentLayer.h:48
> > +    WebContentLayer(const WebContentLayer& l) : WebLayer(l) { }
> 
> webkit generally doesn't like 1-character variable names. in addition, in the font that the webkit review tool uses the glyphs for '1' (one) and 'l' (ell) are pixel-for-pixel identical :'(. can you call this 'layer' instead or something like that?

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.