[Webkit-unassigned] [Bug 69114] DFG does not speculate aggressively enough on put_by_id

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69114





--- Comment #10 from Filip Pizlo <fpizlo at apple.com>  2011-09-30 17:52:37 PST ---
(In reply to comment #9)
> (From update of attachment 109353 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=109353&action=review
> 
> r=me, but you should probably drop the write barrier if the cell is already in the old generation
> 
> > Source/JavaScriptCore/dfg/DFGJITCodeGenerator.cpp:270
> > +void JITCodeGenerator::writeBarrier(GPRReg ownerGPR, JSCell* value, WriteBarrierUseKind useKind, GPRReg scratch1, GPRReg scratch2)
> 
> if value is a cell you can do a generation check (Heap::isMarked()) you can avoid planting this write barrier entirely

Right, good point!  I made that change, will land.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.