[Webkit-unassigned] [Bug 69114] DFG does not speculate aggressively enough on put_by_id

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69114


Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #109353|review?                     |review+
               Flag|                            |




--- Comment #9 from Oliver Hunt <oliver at apple.com>  2011-09-30 16:41:51 PST ---
(From update of attachment 109353)
View in context: https://bugs.webkit.org/attachment.cgi?id=109353&action=review

r=me, but you should probably drop the write barrier if the cell is already in the old generation

> Source/JavaScriptCore/dfg/DFGJITCodeGenerator.cpp:270
> +void JITCodeGenerator::writeBarrier(GPRReg ownerGPR, JSCell* value, WriteBarrierUseKind useKind, GPRReg scratch1, GPRReg scratch2)

if value is a cell you can do a generation check (Heap::isMarked()) you can avoid planting this write barrier entirely

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.