[Webkit-unassigned] [Bug 67311] Add EnabledAtRuntime support for constants.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67311





--- Comment #7 from Aaron Colwell <acolwell at chromium.org>  2011-09-30 10:20:24 PST ---
(From update of attachment 109302)
View in context: https://bugs.webkit.org/attachment.cgi?id=109302&action=review

>> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2113
>>          # handled this here, and converted it to a -1 constant in the c++ output.
> 
> Can you move this comment inside the else branch?  That's really where it belongs.

Done.

>> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2253
>> +        batchConfigureConstants(desc, proto, &constData, 1);
> 
> Its too bad we don't get much of a batching savings here, but I don't see how to avoid that.  Maybe if we grouped by condition?  That doesn't seem worthwhile.

Yeah I didn't like that either, but I figured grouping by condition was going to make this very difficult to read for not a whole lot of gain.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.