[Webkit-unassigned] [Bug 67311] Add EnabledAtRuntime support for constants.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 30 10:01:03 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=67311
Adam Barth <abarth at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #109302|review?, commit-queue? |review+, commit-queue-
Flag| |
--- Comment #6 from Adam Barth <abarth at webkit.org> 2011-09-30 10:01:03 PST ---
(From update of attachment 109302)
View in context: https://bugs.webkit.org/attachment.cgi?id=109302&action=review
> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2113
> # FIXME: we need the static_cast here only because of one constant, NodeFilter.idl
> # defines "const unsigned long SHOW_ALL = 0xFFFFFFFF". It would be better if we
> # handled this here, and converted it to a -1 constant in the c++ output.
Can you move this comment inside the else branch? That's really where it belongs.
> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2253
> + static const BatchedConstant constData = {"${name}", static_cast<signed int>(${value})};
> + batchConfigureConstants(desc, proto, &constData, 1);
Its too bad we don't get much of a batching savings here, but I don't see how to avoid that. Maybe if we grouped by condition? That doesn't seem worthwhile.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list