[Webkit-unassigned] [Bug 68996] [GTK][WEBKIT2] Add Font and Encoding properties to WebKitWebSettings.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68996





--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-09-28 09:08:23 PST ---
(In reply to comment #7)
> (From update of attachment 109023 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=109023&action=review
> 
> >> Source/WebKit2/UIProcess/API/gtk/WebKitWebSettings.cpp:54
> >> +    gchar* defaultEncoding;
> > 
> > Use GOwnPtr<char> for these.
> 
> I recommend using CString instead.

Yes, or CString :-)

> >> Source/WebKit2/UIProcess/API/gtk/WebKitWebSettings.cpp:305
> >> +
> > 
> > We don't need this either.
> 
> If he uses GOwnptr or CString he does.

I think we should use placement new syntax and we don't need that. Or am I wrong? I think I already proposed using it in the other bug about web settings.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.