[Webkit-unassigned] [Bug 68996] [GTK][WEBKIT2] Add Font and Encoding properties to WebKitWebSettings.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68996


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #109023|review?                     |review-
               Flag|                            |




--- Comment #7 from Martin Robinson <mrobinson at webkit.org>  2011-09-28 08:55:52 PST ---
(From update of attachment 109023)
View in context: https://bugs.webkit.org/attachment.cgi?id=109023&action=review

>> Source/WebKit2/UIProcess/API/gtk/WebKitWebSettings.cpp:54
>> +    gchar* defaultEncoding;
> 
> Use GOwnPtr<char> for these.

I recommend using CString instead.

>> Source/WebKit2/UIProcess/API/gtk/WebKitWebSettings.cpp:305
>> +
> 
> We don't need this either.

If he uses GOwnptr or CString he does.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebSettings.cpp:1225
> +    WKStringRef standardFontFamilyRef = WKStringCreateWithUTF8CString(defaultFontFamily);
> +    WKPreferencesSetStandardFontFamily(priv->preferences, standardFontFamilyRef);
> +    priv->defaultFontFamily = static_cast<gchar *> (g_realloc(priv->defaultFontFamily, WKStringGetLength(standardFontFamilyRef) + 1));
> +    WKStringGetUTF8CString(standardFontFamilyRef, priv->defaultFontFamily, WKStringGetLength(standardFontFamilyRef) + 1);
> +    WKRelease(standardFontFamilyRef);
> +

Is it important to refetch the font name from WebKit?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.