[Webkit-unassigned] [Bug 68457] Style changes applied to filtered elements do not invalidate the element

Tue Sep 27 12:02:22 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=68457

--- Comment #16 from Tim Horton <timothy_horton at apple.com>  2011-09-27 12:02:22 PST ---
(In reply to comment #15)
> (In reply to comment #14)
> > Sad that it was landed. I indeed think that this is overkilling! We definitely don't need to invalidate masker, pattern, gradients and clip path on style changes of the target!
> > 
> > Can you please come up with a followup patch that would just clean the resource if it is a filter?
> 
> I share Dirks concerns as well. Sorry for not commenting earlier, I took some days off...
> Anyhow: We have to be very careful when we release anything from the cache, style changes may happen more frequently than you'd expect!
> 
> An easy test would be to add a fprintf(stderr, "INVALIDATE!") before your newly added removeClientFromCache() call - then run all SVG pixel tests and look in the layout-test-results directory for all *stderr.txt files containing "INVALIDATE". I bet it's now firing a lot more often than desired.
> 
> Can you please find this out? I fear this is a large perf regression.

Ok, I'll fix this today. I've been looking around trying to come up with cases where target style changes would require a master/pattern/gradient/clipPath and could come up with nothing, so sure, we'll only do it in the case of filters. Does that work?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.