[Webkit-unassigned] [Bug 68457] Style changes applied to filtered elements do not invalidate the element

Tue Sep 27 11:55:08 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=68457

--- Comment #15 from Nikolas Zimmermann <zimmermann at kde.org>  2011-09-27 11:55:08 PST ---
(In reply to comment #14)
> Sad that it was landed. I indeed think that this is overkilling! We definitely don't need to invalidate masker, pattern, gradients and clip path on style changes of the target!
> 
> Can you please come up with a followup patch that would just clean the resource if it is a filter?

I share Dirks concerns as well. Sorry for not commenting earlier, I took some days off...
Anyhow: We have to be very careful when we release anything from the cache, style changes may happen more frequently than you'd expect!

An easy test would be to add a fprintf(stderr, "INVALIDATE!") before your newly added removeClientFromCache() call - then run all SVG pixel tests and look in the layout-test-results directory for all *stderr.txt files containing "INVALIDATE". I bet it's now firing a lot more often than desired.

Can you please find this out? I fear this is a large perf regression.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.