[Webkit-unassigned] [Bug 68866] CompositeEditCommand::prune should remove subtree at once

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 27 09:53:32 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=68866





--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org>  2011-09-27 09:53:31 PST ---
(From update of attachment 108786)
View in context: https://bugs.webkit.org/attachment.cgi?id=108786&action=review

>> Source/WebCore/ChangeLog:9
>> +        This reduces the number of node removals from O(n) to O(1) where n is the depth of the tree.
> 
> Can we make a performance test demonstrating this fix? Ojan’s performance harness typically makes that easy.

Unfortunately not. This function isn't exposed to DRT or is used in any obvious way by an editing command to test it.

I could tweak breakOutOfEmptyMailBlockquotedParagraph to call this function but that seems like a bad testing strategy because any changes to breakOutOfEmptyMailBlockquotedParagraph will invalidate the test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list