[Webkit-unassigned] [Bug 68866] CompositeEditCommand::prune should remove subtree at once

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68866





--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org>  2011-09-27 09:46:11 PST ---
(From update of attachment 108786)
View in context: https://bugs.webkit.org/attachment.cgi?id=108786&action=review

>> Source/WebCore/editing/CompositeEditCommand.cpp:254
>> +            n = n->nextSibling();
> 
> I think you want:
> 
>     n = n->traverseNextSibling(node);
> 
> here, not just nextSibling.

Ah, you're right. Will fix.

>> Source/WebCore/editing/CompositeEditCommand.cpp:277
>> +void CompositeEditCommand::prune(PassRefPtr<Node> prpNode)
> 
> Normally we only use the "prp" naming if we are transferring ownership to a local variable with a simpler name. Since we’re not doing that here, a prp prefix is not necessary.

Will fix.

>> Source/WebCore/editing/CompositeEditCommand.cpp:280
>> +        removeNode(highestNodeToRemove);
> 
> This should probably have a “release” in it.

Good point. Will do.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.