[Webkit-unassigned] [Bug 68597] DFG JIT should support integer division

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68597





--- Comment #6 from Filip Pizlo <fpizlo at apple.com>  2011-09-22 11:44:57 PST ---
> > Source/JavaScriptCore/jit/JITArithmetic.cpp:1058
> > +    // in the heap to go doubly, resulting in double predictions getting predicted to all
> 
> What’s "go doubly"? Do you just mean "go double"? Or get a double value?

I've been using that to distinguish between something having actual honest doubles (i.e. formatted as double because they cannot be represented as integer) and having an odd mix of integers formatted as int32 and integers formatted as double for no reason other than somewhere in the code we were too lazy to realize we were producing integers.

> 
> > Source/JavaScriptCore/jit/JITArithmetic.cpp:1062
> > +    // FIXME: This will fail to do its magic if the result is zero.
> 
> This comment would be clearer if “fail to do its magic” was replaced by a more specific phrase.

"fail to do its magic" = convert the double back to an integer.  I'll fix that comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.