[Webkit-unassigned] [Bug 68597] DFG JIT should support integer division

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68597


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #108295|review?                     |review+
               Flag|                            |




--- Comment #5 from Darin Adler <darin at apple.com>  2011-09-22 10:31:50 PST ---
(From update of attachment 108295)
View in context: https://bugs.webkit.org/attachment.cgi?id=108295&action=review

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:549
> +        // have speculatins in place that take care of that separately. We only

Typo: speculations

> Source/JavaScriptCore/jit/JITArithmetic.cpp:1058
> +    // in the heap to go doubly, resulting in double predictions getting predicted to all

What’s "go doubly"? Do you just mean "go double"? Or get a double value?

> Source/JavaScriptCore/jit/JITArithmetic.cpp:1062
> +    // FIXME: This will fail to do its magic if the result is zero.

This comment would be clearer if “fail to do its magic” was replaced by a more specific phrase.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.