[Webkit-unassigned] [Bug 67946] Use WebCore platform interfaces for MediaStream API and PeerConnection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67946





--- Comment #12 from Adam Bergkvist <adam.bergkvist at ericsson.com>  2011-09-19 01:50:02 PST ---
(In reply to comment #11)
> (From update of attachment 107159 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=107159&action=review
> 
> This patch is too large to review, but I like the approach of moving a bunch of the code into WebCore/platform.

Thanks for taking the time to look at the patch even though it's large. I knew that it's too large to be reviewed and that's why I labeled it "patch for discussion" (without review-flag and ChangeLog). The idea is to get people on board with the proposed changes and then submit smaller patches.

> Renaming p2p to mediastream also seems beneficial, but a slightly separable concern.

We're not simply renaming p2p to mediastream, but also gathering various MediaStream-related files from WebCore/dom, WebCore/page and WebCore/platform in this new folder.

> > Source/WebCore/platform/mediastream/PeerHandler.h:76
> > +class PeerHandlerClient {
> 
> These classes in WebCore/platform shouldn't be called Clients.  In WebKit, the client exist to talk with "up" to the WebKit Client, not "down" to the platform.

The PeerHandlerClient interface is used by PeerHandler to talk "up" to PeerConnection much like HTMLMediaElement is a MediaPlayerClient. However, we don't have a strong opinion about the name.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.