[Webkit-unassigned] [Bug 67946] Use WebCore platform interfaces for MediaStream API and PeerConnection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67946





--- Comment #11 from Adam Barth <abarth at webkit.org>  2011-09-16 10:20:49 PST ---
(From update of attachment 107159)
View in context: https://bugs.webkit.org/attachment.cgi?id=107159&action=review

This patch is too large to review, but I like the approach of moving a bunch of the code into WebCore/platform.  Renaming p2p to mediastream also seems beneficial, but a slightly separable concern.

I also like that you're using ActiveDOMObject rather than the Frame- and Page-level controller objects.  That's good improvement to the design.

> Source/WebCore/platform/mediastream/PeerHandler.h:76
> +class PeerHandlerClient {

These classes in WebCore/platform shouldn't be called Clients.  In WebKit, the client exist to talk with "up" to the WebKit Client, not "down" to the platform.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.