[Webkit-unassigned] [Bug 67952] Ask for audio hardware buffer size instead of using hardwired constants.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67952





--- Comment #22 from Raymond Toy <rtoy at chromium.org>  2011-09-16 15:15:41 PST ---
(From update of attachment 107710)
View in context: https://bugs.webkit.org/attachment.cgi?id=107710&action=review

>> Source/WebKit/chromium/src/AudioDestinationChromium.cpp:47
>> +const size_t minimumCallbackBufferSize = 128;
> 
> I wouldn't create a new constant here, but instead use the already existing constant "renderBufferSize"

Although they have the same value, they're conceptually different things.  Do you think overloading the meaning is appropriate?

>> Source/WebKit/chromium/src/AudioDestinationChromium.cpp:74
>> +    ASSERT((minimumCallbackBuffersize <= m_callbackBuffersize)
> 
> I would suggest something like this:
> 
> bool isSizeGood = m_callbackBuffersize >= renderBufferSize && m_callbackBuffersize <= maximumCallbackBufferSize;
> ASSERT(isSizeGood);
> if (!isSizeGood)
>     return;

Yes, I'll do this in the next patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.