[Webkit-unassigned] [Bug 67952] Ask for audio hardware buffer size instead of using hardwired constants.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67952





--- Comment #21 from Chris Rogers <crogers at google.com>  2011-09-16 13:41:00 PST ---
(From update of attachment 107710)
View in context: https://bugs.webkit.org/attachment.cgi?id=107710&action=review

> Source/WebKit/chromium/src/AudioDestinationChromium.cpp:47
> +const size_t minimumCallbackBufferSize = 128;

I wouldn't create a new constant here, but instead use the already existing constant "renderBufferSize"

> Source/WebKit/chromium/src/AudioDestinationChromium.cpp:74
> +    ASSERT((minimumCallbackBuffersize <= m_callbackBuffersize)

I would suggest something like this:

bool isSizeGood = m_callbackBuffersize >= renderBufferSize && m_callbackBuffersize <= maximumCallbackBufferSize;
ASSERT(isSizeGood);
if (!isSizeGood)
    return;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.