[Webkit-unassigned] [Bug 68209] New: [EFL] Change WebKit EFL coding style

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68209

           Summary: [EFL] Change WebKit EFL coding style
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit EFL
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: gyuyoung.kim at samsung.com
                CC: demarchi at webkit.org, gyuyoung.kim at webkit.org


WebKit EFL port has used EFL coding style. However, EFL port has used C-coding style despite files are C++. In addition, this style disturbed reviewers to review EFL patches. So, we discussed this issues by means of webkit-efl mailing list.  https://lists.webkit.org/pipermail/webkit-efl/2011-September/000049.html 

I list current issues up as below. And, this bug is a meta bug to track this issues.

1. pointer operator coding style based on efl coding style.
   : pointer('*') operator coding style follows efl coding style. It looks we need to adhere webkit coding style.

2. Should we use EINA_TRUE and EINA_FALSE?
   : It can be replace with true / false.  

3. Internal functions are using '(void)' parameter.
   : As we already discussed, internal function needs to use C++ coding style.

4. Manual memory management.
   : ewk_xxx files are using malloc, calloc and realloc instead of smart pointer.
      For example, GOwnPtr.

5. C style casting operator.
   : Though file format is .cpp, some codes are still using c type casting operator.

6. Meaningless parameter name.
   : We have used coding style of efl parameter so far. However, that is not webkit coding style.
      I heard that port implementation tends to be platform coding style. So, I added a parameter coding style exception to 
      style checker for efl port. But, now I'm not sure whether we're able to use it continually.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.