[Webkit-unassigned] [Bug 62842] [EFL] Change behavior of ewk_view_zoom_get/set to call Frame::scalePage.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62842





--- Comment #11 from Gustavo Sverzut Barbieri <barbieri at profusion.mobi>  2011-09-15 10:05:12 PST ---
Page scale is just another way of zooming. Actually it's the most logical way, just the most inefficient. :-)

Text-zoom is something that goes bit far from what people understand as zoom, but it is very useful for people with eye problems or different media. For instance, viewing a webpage on TV: you can spot icons and such, but hardly you can read a phrase with regular font size and want it doubled or so.

About your proposal: one more parameter to zoom_set() is bad. What do you get when you zoom_get()? Will be confusing for sure!

When I designed zoom_set() to operate on one of actual zoom or text I imagined the user would use just one or another. But as you mentioned the case of using both is reasonable.

If we're changing our API, why not change it for good and keep 1:1 with WebKit? If so then (with matching getters, of course):

   - ewk_{view,frame}_scale_set(o, factor, center_x, center_y);
   - ewk_{view,frame}_text_zoom_set(o, factor);
   - ewk_{view,frame}_zoom_set(o, factor).

I removed center point from regular zoom as it will not make much sense. Hardly the page contents will match (paragraphs will re-flow, etc) and thus not of much help.

Code in WebKit-EFL will be minimal, just C<->C++ bridge and the behavior will be consistent. Browsers will need to be changed, but that is very simple.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.