[Webkit-unassigned] [Bug 62842] [EFL] Change behavior of ewk_view_zoom_get/set to call Frame::scalePage.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62842





--- Comment #10 from Ryuan Choi <ryuan.choi at samsung.com>  2011-09-14 16:37:26 PST ---
(In reply to comment #9)
> r-
> 
> Not everyone is mobile and want to scale page on zoom. How about desktop users that want text-only zoom? How about regular zoom that uses proper font size instead of scaled vectors? Users of low-end hardware, like some TVs will be hurt by such behavior.
> 

I don't want to remove text-only zoom and page zoom.
scale page is additional feature.

> Given the way we already do by having "ewk_view_zoom_text_only_set()", we could remove it and make an enum of zoom modes.
> 
> Or introduce another ewk_{view,frame}_zoom_scaled_set() and note that is just applied if text_only is False. Effectively ewk_frame_zoom_set() would become:
> 
> 
>     if (sd->textZoom)
>         sd->frame->setTextZoomFactor(zoom);
>     else if (sd->scaledZoom)
>         sd->frame->scalePage(zoom, WebCore::IntPoint(x, y));
>     else
>         sd->frame->setPageZoomFactor(zoom);
> 

Basically, It make sense for me. I'll do that.

However,
IMO, ewk_view_zoom_text_only_set() limit zoom feature.
For example, we can't get 2.0 page zoomed and 3.0 text zoomed contents.

I prefer to add enum parameter in ewk_{view, frame}_zoom_get() with removing ewk_view_zoom_text_only_{get,set}().

I know that API changes is not good.
I'll prepare new patch after getting opinion from webkit-efl mailing list.

> ewk_frame_zoom_set() is not widely used (its usage is discouraged for regular users) and thus can start to take x,y parameters if you think it's necessary.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.