[Webkit-unassigned] [Bug 67190] A Media Element ie: <Audio> or <video>, without tabindex cannot be selected with keyboard (TAB Key).

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67190


Antonio Gomes <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107160|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #20 from Antonio Gomes <tonikitoo at webkit.org>  2011-09-15 07:31:25 PST ---
(From update of attachment 107160)
View in context: https://bugs.webkit.org/attachment.cgi?id=107160&action=review

r=me. Please address Ryosuke's concerns before committing.

When you have a new patch, pre-fill "Reviewed by Antonio Gomes" field, and set cq? only. Then any committer can cq+ it.

> LayoutTests/fast/events/tabindex-focus-blur-all-expected.txt:1
> -331 focus / 331 blur events dispatched, and should be 331 / 331 PASSED
> +333 focus / 333 blur events dispatched, and should be 333 / 333 PASSED

this part looks suspicious.

> LayoutTests/fast/events/resources/tabindex-focus-blur-all.js:57
> -    var resultSummary = focusCount+" focus / "+blurCount+" blur events dispatched, and should be 331 / 331 ";
> +    var resultSummary = focusCount+" focus / "+blurCount+" blur events dispatched, and should be 333 / 333 ";

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.