[Webkit-unassigned] [Bug 67190] A Media Element ie: <Audio> or <video>, without tabindex cannot be selected with keyboard (TAB Key).

Wed Sep 14 09:50:14 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=67190

--- Comment #19 from Ryosuke Niwa <rniwa at webkit.org>  2011-09-14 09:50:13 PST ---
(From update of attachment 107160)
View in context: https://bugs.webkit.org/attachment.cgi?id=107160&action=review

> LayoutTests/fast/events/media-element-focus-tab.html:1
> +<p>This tests that a media element ie: <code><Audio></code> or <code><video></code>, without tabindex can be selected with keyboard (TAB Key)</p>

no DOCTYPE, html , & body?

> LayoutTests/fast/events/media-element-focus-tab.html:45
> +        document.getElementById("console").innerHTML +=  mediaFocusedMsg + " TEST: " + fieldId + ".\n";

Nit: two spaces after +=.

> LayoutTests/fast/events/media-element-focus-tab.html:54
> +test("WithTabIndexVideo", "SUCCESS: Tab-Key did tab to the Media Element (video1).", "FAIL: Tab-Key did not tab to the Media Element (video1).");
> +test("WithoutTabIndexVideo", "SUCCESS: Tab-Key did tab to the Media Element (video2).", "FAIL: Tab-Key did not tab to the Media Element (video2).");
> +test("WithoutControlsButWithTabIndexVideo", "SUCCESS: Tab-Key did tab to the Media Element (video3).", "FAIL: Tab-Key did not tab to the Media Element (video3).");
> +test("WithoutTabIndexAudio", "SUCCESS: Tab-Key did tab to the Media Element (audio1).", "FAIL: Tab-Key did not tab to the Media Element (audio1).");
> +test("WithoutControlaAndTabIndexAudio", "FAIL: Tab-Key did tab to the Media Element (audio2).", "SUCCESS: Tab-Key did not tab to the Media Element (audio2).");

Duplicating all these pass/fail messages seem inelegant to me.  You should be able to create one in test by string concatenations.

> LayoutTests/fast/spatial-navigation/snav-media-elements.html:1
> +<html>

No DOCTYPE?

> LayoutTests/fast/spatial-navigation/snav-media-elements.html:8
> +      ["Down", "v1"],

Maybe up should try up first?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.