[Webkit-unassigned] [Bug 68079] Set but unused variables cleanup in v8 bindings (gcc 4.6)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68079





--- Comment #4 from ph34r <pph34r at gmail.com>  2011-09-14 22:57:09 PST ---
> > Source/WebCore/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:105
> >          imp->setLength(value->Uint32Value(), ec);
> 
> Are you sure we're not supposed to use newLength there?

Of course I'm not sure, as I'm not so familiar with the codebase :) My only goal was to fix about 500+ warnings that pops up during Chromium build. But as far as I could see there was no intended use of this variable, so why don't we add extra variables when it will be really needed?


> > Source/WebCore/bindings/v8/custom/V8WebSocketCustom.cpp:137
> > -        v8::Handle<v8::String> stringMessage = message->ToString();
> > +        message->ToString();
> 
> What's the point of calling ToString on this object and ignoring the result?

I thought the point was in the exception checking, as it was surrounded by "try catch"

Any suggestions?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.