[Webkit-unassigned] [Bug 68079] Set but unused variables cleanup in v8 bindings (gcc 4.6)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68079


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107336|review?                     |review-
               Flag|                            |




--- Comment #3 from Adam Barth <abarth at webkit.org>  2011-09-14 11:59:44 PST ---
(From update of attachment 107336)
View in context: https://bugs.webkit.org/attachment.cgi?id=107336&action=review

> Source/WebCore/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:105
>          imp->setLength(value->Uint32Value(), ec);

Are you sure we're not supposed to use newLength there?

> Source/WebCore/bindings/v8/custom/V8WebSocketCustom.cpp:137
> -        v8::Handle<v8::String> stringMessage = message->ToString();
> +        message->ToString();

What's the point of calling ToString on this object and ignoring the result?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.