[Webkit-unassigned] [Bug 67469] IconDatabase::defaultIcon always fails for non-CAN_THEME_URL_ICON builds.

Wed Sep 14 15:25:33 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=67469

Brady Eidson <beidson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|IconDatabase::defaultIcon   |IconDatabase::defaultIcon
                   |always fails because        |always fails for
                   |loadDefaultIconRecord       |non-CAN_THEME_URL_ICON
                   |returns a TIFF              |builds.

--- Comment #3 from Brady Eidson <beidson at apple.com>  2011-09-14 15:25:33 PST ---
(In reply to comment #2)
> I am developing with the WinCairo branch but this should have zero effect on the outcome. If you look closely at the code path starting at getOrCreateDefaultIconBitmap you should discover that it is impossible for this function to succeed unless CAN_THEME_URL_ICON is defined.

Then this will only work for CAN_THEME_URL_ICON builds.  :)

> Would you like me to modify WinLauncher so that it reveals the access violation? All that you need to do is instantiate an instance of IWebIconDatabase and call iconForURL for any domain without a favicon.

We don't use WinLauncher extensively, if at all.  

> 
> Best Wishes,
> -David Delaune

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.