[Webkit-unassigned] [Bug 67469] IconDatabase::defaultIcon always fails because loadDefaultIconRecord returns a TIFF

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67469





--- Comment #2 from David Delaune <david.delaune at hotmail.com>  2011-09-14 15:11:15 PST ---
I am developing with the WinCairo branch but this should have zero effect on the outcome. If you look closely at the code path starting at getOrCreateDefaultIconBitmap you should discover that it is impossible for this function to succeed unless CAN_THEME_URL_ICON is defined.

loadDefaultIconRecord() returns a TIFF hard-coded into a static buffer. Following the code path you should find that ImageDecoder::create never checks for a TIFF header and will always result in a NULL ImageDecoder* pointer.

Would you like me to modify WinLauncher so that it reveals the access violation? All that you need to do is instantiate an instance of IWebIconDatabase and call iconForURL for any domain without a favicon.

Best Wishes,
-David Delaune

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.