[Webkit-unassigned] [Bug 40351] [chromium] Can't handle deletion of characters beyond U+10000.

Mon Sep 5 18:16:00 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=40351

Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #106334|review?                     |review-
               Flag|                            |

--- Comment #5 from Kent Tamura <tkent at chromium.org>  2011-09-05 18:16:00 PST ---
(From update of attachment 106334)
View in context: https://bugs.webkit.org/attachment.cgi?id=106334&action=review

>> Source/WebCore/rendering/RenderText.cpp:1671
>> +#if PLATFORM(MAC) || defined(OS_MACOSX)
> 
> I don't know if all other ports want this behavior when running on OS X, although I would certainly encourage them to.

OS_MACOSX is a macro used only in Chromium, and we should not use it here. We should write

#if PLATFORM(MAC) || PLATFORM(CHROMIUM) && OS(MAC_OS_X)

or

#if OS(DARWIN)
if you'd like to include iOS and Qt/Mac.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.