[Webkit-unassigned] [Bug 67590] Implement DRT support for Android.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 5 03:16:44 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=67590
--- Comment #3 from Hao Zheng <zhenghao at chromium.org> 2011-09-05 03:16:44 PST ---
(In reply to comment #2)
> (From update of attachment 106315 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=106315&action=review
>
> > Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:68
> > +static const char optionPrintReady[] = "--print-ready";
>
> 'print-ready' seems like an odd name, as there's no visible printing as far as the user of the tool is concerned. How about 'send-ready-command' or similar?
>
How about 'send-ready'?
> > Tools/DumpRenderTree/chromium/LayoutTestController.cpp:63
> > +#include <clocale>
>
> Why are these needed on Android? If this is a deficiency in bionic, we should have a bug to track this, like in http://code.google.com/p/android/issues/detail?id=19764
>
I don't think it's a bug in bionic, because LC_ALL should be defined in clocale and tolower should be in cctype. I guess we can build DRT on other platforms because other headers happen to include the defines, so explicitly including the files here should be fine.
> > Tools/DumpRenderTree/chromium/TestShellAndroid.cpp:58
> > + signal(SIGALRM, AlarmHandler);
>
> The signal() man page recommends using sigaction() instead.
>
Ok.
> > Tools/DumpRenderTree/chromium/TestShellAndroid.cpp:77
> > +}
>
> Will these methods ever be implemented? I think you should add a comment/FIXME/DCHECK etc.
I do not expect they will be implemented. Anyway, I will add some comments.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list