[Webkit-unassigned] [Bug 67590] Implement DRT support for Android.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67590





--- Comment #2 from Steve Block <steveblock at google.com>  2011-09-05 02:46:07 PST ---
(From update of attachment 106315)
View in context: https://bugs.webkit.org/attachment.cgi?id=106315&action=review

> Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:68
> +static const char optionPrintReady[] = "--print-ready";

'print-ready' seems like an odd name, as there's no visible printing as far as the user of the tool is concerned. How about 'send-ready-command' or similar?

> Tools/DumpRenderTree/chromium/LayoutTestController.cpp:63
> +#include <clocale>

Why are these needed on Android? If this is a deficiency in bionic, we should have a bug to track this, like in http://code.google.com/p/android/issues/detail?id=19764

> Tools/DumpRenderTree/chromium/TestShellAndroid.cpp:58
> +    signal(SIGALRM, AlarmHandler);

The signal() man page recommends using sigaction() instead.

> Tools/DumpRenderTree/chromium/TestShellAndroid.cpp:77
> +}

Will these methods ever be implemented? I think you should add a comment/FIXME/DCHECK etc.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.