[Webkit-unassigned] [Bug 70765] Default <select multiple> expands up to 10 items instead of showing 4

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70765





--- Comment #4 from Antaryami Pandia <xqb748 at motorola.com>  2011-10-31 22:51:56 PST ---
(In reply to comment #3)
> (From update of attachment 113026 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=113026&action=review
> 
> > Source/WebCore/rendering/RenderListBox.cpp:217
> > +        return max(defaultSize, specifiedSize);
> 
> This change is incorrect. The default size and the minimum are not the same thing. We have a minimum of 4 because of the minimum size that is big enough so a scrollbar works. Platforms that do scrolling with different scrollbar designs might even want a different minimum. This is not the same number as the 4 in the HTML standard.

Thanks for the clarification.

> > Source/WebCore/rendering/RenderListBox.cpp:218
> > +    return min(defaultSize, numItems());
> 
> This is not what the specification says. It says that the size should be 4 even if there is only 1 item. And the old code did that. You are removing that old minimum size of 4 here.

Yes.I will modify.

Will upload a modified patch after incorporating your review comments.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.