[Webkit-unassigned] [Bug 70765] Default <select multiple> expands up to 10 items instead of showing 4

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70765


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #113026|review?                     |review-
               Flag|                            |




--- Comment #3 from Darin Adler <darin at apple.com>  2011-10-31 16:26:18 PST ---
(From update of attachment 113026)
View in context: https://bugs.webkit.org/attachment.cgi?id=113026&action=review

> Source/WebCore/rendering/RenderListBox.cpp:217
> +        return max(defaultSize, specifiedSize);

This change is incorrect. The default size and the minimum are not the same thing. We have a minimum of 4 because of the minimum size that is big enough so a scrollbar works. Platforms that do scrolling with different scrollbar designs might even want a different minimum. This is not the same number as the 4 in the HTML standard.

> Source/WebCore/rendering/RenderListBox.cpp:218
> +    return min(defaultSize, numItems());

This is not what the specification says. It says that the size should be 4 even if there is only 1 item. And the old code did that. You are removing that old minimum size of 4 here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.