[Webkit-unassigned] [Bug 70995] The GC should be parallel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70995





--- Comment #35 from Filip Pizlo <fpizlo at apple.com>  2011-10-31 19:41:49 PST ---
(In reply to comment #34)
> (From update of attachment 113121 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=113121&action=review
> 
> r=me, with build fixed.
> 
> > Source/JavaScriptCore/wtf/Atomics.h:123
> > +#if ENABLE(COMPARE_AND_SWAP)
> 
> Maybe better just to put the #if around the whole function definition. That way, if you try to use this on the wrong platform, you fail at compile time.

Can't quite do it.  Bitmap calls weakCompareAndSwap conditionally, and even though with CAS/PARALLEL_GC disabled Bitmap doesn't get instantiated in a way that would result in calls to weakCompareAndSwap, the compiler will still complain.

I suppose you could have Bitmap accept some manner of template CAS functor ... but that seems like brutal overkill.  Or I could #ifdef out the calls to weakCompareAndSwap in Bitmap, but that seems like more bloat as well.

Do you have anything against having weakCompareAndSwap always declared, as it is now, with the CRASH() thingy?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.