[Webkit-unassigned] [Bug 70995] The GC should be parallel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70995


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #113121|review?                     |review+
               Flag|                            |




--- Comment #34 from Geoffrey Garen <ggaren at apple.com>  2011-10-31 19:27:14 PST ---
(From update of attachment 113121)
View in context: https://bugs.webkit.org/attachment.cgi?id=113121&action=review

r=me, with build fixed.

> Source/JavaScriptCore/wtf/Atomics.h:123
> +#if ENABLE(COMPARE_AND_SWAP)

Maybe better just to put the #if around the whole function definition. That way, if you try to use this on the wrong platform, you fail at compile time.

FWIW, TCSpinLock.h has some multi-platform CAS assembly code that could be merged into this. Doesn't need to hold up this patch, though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.