[Webkit-unassigned] [Bug 70395] REGRESSION: rtl horizontal scrollbar / resize bug - Body shifts on resize when scrolled all the way to the left

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70395





--- Comment #14 from Xiaomei Ji <xji at chromium.org>  2011-10-28 17:51:31 PST ---
(In reply to comment #13)
> (From update of attachment 112805 [details])
> I don't know this code well enough to review this patch, however, I have 2 suggestions:
> 1) Do a refactor patch first that adds the getter methods and makes the member variables private.  This will make the patch much smaller.

Good suggestion!

> 2) I don't really like m_scrollOriginChanged.  It's hard to tell when you're supposed to set it and when it's valid to read it.  It would be more clear to pass the bool around where needed.

it would be nice to pass the bool around. but the problem is updateScrollbar() might not be called Synchronously when m_scrollOrigin changes, besides m_scrollOrigin could be changed in RenderLayer as well.

I tried to modify updateScrollbar() with an extra bool parameter, and change the caller side to pass true/false depends on the functionality. But that introduce more un-necessary scrolling.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.