[Webkit-unassigned] [Bug 70395] REGRESSION: rtl horizontal scrollbar / resize bug - Body shifts on resize when scrolled all the way to the left

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 28 17:22:19 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=70395





--- Comment #13 from Tony Chang <tony at chromium.org>  2011-10-28 17:22:19 PST ---
(From update of attachment 112805)
I don't know this code well enough to review this patch, however, I have 2 suggestions:
1) Do a refactor patch first that adds the getter methods and makes the member variables private.  This will make the patch much smaller.
2) I don't really like m_scrollOriginChanged.  It's hard to tell when you're supposed to set it and when it's valid to read it.  It would be more clear to pass the bool around where needed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list