[Webkit-unassigned] [Bug 71052] [GTK] Visited links of a page group should be removed when clearing back/forward list

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71052





--- Comment #3 from Zan Dobersek <zandobersek at gmail.com>  2011-10-28 13:55:30 PST ---
(From update of attachment 112898)
View in context: https://bugs.webkit.org/attachment.cgi?id=112898&action=review

>> Source/WebKit/gtk/webkit/webkitwebbackforwardlist.cpp:463
>> +    if (page && page->groupPtr())
> 
> I think it's okay to do this here since other ports do it, but we should update the documentation to state that when a list is cleared it also clears the list of visisted links.

Noted & done.

>> LayoutTests/platform/gtk/fast/block/margin-collapse/010-expected.txt:31
>>            RenderText {#text} at (259,0) size 49x19
> 
> Can you also run these tests in WebKit2? I'm surprised that they weren't failing before there.

Running the tests in WebKit2 is actually where I noticed that Gtk port holds onto visited links and is the only port to do so. WebKitTestRunner is structured in a way that the usage of WebKit2 does not vary that much between the ports, so the other ports didn't have these problems while these errors were popping up for me. With this patch these tests would also start passing when running the tests in WebKit2.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.