[Webkit-unassigned] [Bug 71052] [GTK] Visited links of a page group should be removed when clearing back/forward list

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71052


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #112898|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2011-10-28 13:20:14 PST ---
(From update of attachment 112898)
View in context: https://bugs.webkit.org/attachment.cgi?id=112898&action=review

Awesome! I have a couple comments below:

> Source/WebKit/gtk/webkit/webkitwebbackforwardlist.cpp:463
> +    if (!backForwardList)
> +        return;
> +
> +    WebCore::Page* page = backForwardList->page();
> +    if (page && page->groupPtr())

I think it's okay to do this here since other ports do it, but we should update the documentation to state that when a list is cleared it also clears the list of visisted links.

> LayoutTests/platform/gtk/fast/block/margin-collapse/010-expected.txt:31
> -        RenderInline {A} at (0,0) size 49x19 [color=#551A8B]
> +        RenderInline {A} at (0,0) size 49x19 [color=#0000EE]
>            RenderText {#text} at (259,0) size 49x19

Can you also run these tests in WebKit2? I'm surprised that they weren't failing before there.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.