[Webkit-unassigned] [Bug 70952] [Qt] Support the Web Open Font Format (WOFF)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70952





--- Comment #3 from Simon Hausmann <hausmann at webkit.org>  2011-10-28 00:36:30 PST ---
(From update of attachment 112577)
View in context: https://bugs.webkit.org/attachment.cgi?id=112577&action=review

>> Source/WebCore/WebCore.pri:144

> 
> So we are introducing another dependency... I guess it is alright, but can you check with Simon?

This breaks the (native) build on Windows and technically it also requires changes on non-Windows to get the include path right. zlib.h isn't _guaranteed_ to be in /usr/include strictly speaking. If possible we should be using pkg-config then (and I guess on mac we can rely on fixed paths).

Options for Windows I can think of:

1) No support the feature there (urgh)
2) Pull in src/3rdparty/zlib.pri from the Qt sources (tricky)
3) In addition to 1 or 2, introduce the _option_ of building against a shared zlib on Windows with the ability to specify the include path and library path (or make take implicitly through INCLUDES/LIBS env)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.