[Webkit-unassigned] [Bug 70953] New: Chromium ui_tests WorkerTest.WorkerMessagePort[GC] were broken by https://bugs.webkit.org/attachment.cgi?id=112342

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70953

           Summary: Chromium ui_tests WorkerTest.WorkerMessagePort[GC]
                    were broken by
                    https://bugs.webkit.org/attachment.cgi?id=112342
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
               URL: http://crbug.com/101665
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit API
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: dmichael at chromium.org
                CC: levin at chromium.org


In http://trac.webkit.org/changeset/98381, I changed PlatformMessagePortChannel::hasPendingActivity thusly:
 bool PlatformMessagePortChannel::hasPendingActivity()
 {
     MutexLocker lock(m_mutex);
-    return m_localPort;
+    return m_localPort && m_localPort->hasPendingActivity();
 }

I suspect the new code is 'right' (in that I think it provides the originally _intended_ behavior), but existing code elsewhere must depend on the previous behavior.

I'm planning to undo this part of CS 98381, and hoping that somebody else more familiar with existing PlatformMessagePortChannels can fix the problem with this function and its caller(s) (if there is a problem).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.