[Webkit-unassigned] [Bug 70617] Optional "keytype" attribute for the <keygen> tag is handled incorrectly in appendFormData().

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70617





--- Comment #15 from Gaurav Shah <gauravsh at chromium.org>  2011-10-26 16:32:56 PST ---
(In reply to comment #12)
> (In reply to comment #11)
> > (In reply to comment #10)
> > > However, to make that work I need to remove the following check from appendForm():
> > > 
> > > if (value.isNull())
> > >   return false;
> > > 
> > > WebKit test runs (I tested this by building WebKit for chromium) seem to stub it out returning an empty String, causing the above check to fail.
> > 
> > If test runs returned an empty string, then that check would not fail. There is a distinct empty string and null string. If you want to change the stub to return an empty string instead of a null string, that’s OK with me. Making that change should not be difficult.
> 
> It occurs to me that for testing, it would be even better to change this to return some placing string that is helpful to interpret the test output rather than an empty string. That might be easy to do.

This would be fine if there was a concept of mock/stub implementations which gets used during test runs. The Chromium implementation, for example, re-use the stub implementation while building tests for the Chromium Webkit port.

Side Note: To do this for all ports is quite complicated. Right now there are no universal stub/mock implementations of these platform-specific methods that get used across all ports during tests. (See my earlier comment about Chromium's stub implementation coming from its glue layer whose sources are not part of WebKit)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.