[Webkit-unassigned] [Bug 70617] Optional "keytype" attribute for the <keygen> tag is handled incorrectly in appendFormData().

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70617





--- Comment #14 from Gaurav Shah <gauravsh at chromium.org>  2011-10-26 16:07:59 PST ---
(In reply to comment #11)
> (In reply to comment #10)
> > However, to make that work I need to remove the following check from appendForm():
> > 
> > if (value.isNull())
> >   return false;
> > 
> > WebKit test runs (I tested this by building WebKit for chromium) seem to stub it out returning an empty String, causing the above check to fail.
> 
> If test runs returned an empty string, then that check would not fail. There is a distinct empty string and null string. If you want to change the stub to return an empty string instead of a null string, that’s OK with me. Making that change should not be difficult.
> 

I can make that change. Chromium's stub implementation comes from the glue code, so I need to first land a chromium change first. For qt and efl, there are already stub implementations which I can modify to return an empty string. I am not sure about the Mac or Windows case though. From my reading of it, they don't use stub implementations during tests. 

Looks like the simplest route is to just make this test run on the chromium port.

> > I would argue that receiving an empty post request is worse (which happens now when keygen processing fails on the client) than receiving an empty "name= " POST (with this change).
> 
> If we’re going to actually consider changing the WebCore code then lets not talk about which of these two worse, lets talk about what desired behavior would be. Are there any real-world examples where keygen fails. If so, what would be the best possible behavior for that case and why? But lets discuss this in another bug, because there is no need for you to change WebCore just to make the test work.


Fair enough. Agreed that the discussion is better done in a separate bug. (To answer your question: keygen depends on the platform specific crypto library implementation and there are many reasons why it would fail - misconfigured library or crypto hardware, etc.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.